search

jaredhanson / passport-oauth2

OAuth 2.0 authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-oauth2/?utm_source=github&utm_medium=referral&utm_campaign=passport-oauth2&utm_content=about
MIT License
602 stars 343 forks source link

`node-oauth` throws intermittent InternalOAuthErrors on fast connections #163

Open 8bitDesigner opened 2 years ago

8bitDesigner commented 2 years ago

Hi all, there's an existing bug with passport-google-oauth2 where, due to an upstream issue in node-oauth 0.9.0, OAuthing into Google accounts fails intermittently over fast connections.

Good news! The upstream issue has been fixed and published as node-oauth 0.10.0. However passport-google-oauth2 depends on this package, and this package is pinned at node-oauth 0.9.x. Can you bump this dependency to 0.10.0 and publish a new version?

Quentin-Danjou commented 2 years ago

Here is the change made on node-oauth (named oauth in the dependencies) from the current version used by passport-oauth2 (0.9.x) to the 0.10.0: https://github.com/ciaranj/node-oauth/compare/0.9.15...0.10.0 (made by https://github.com/ciaranj/node-oauth/pull/363)

Once the version will be bumped this will solve several duplicated issues in passport-google-oauth2 as said by @8bitDesigner, such as https://github.com/jaredhanson/passport-google-oauth2/issues/87, https://github.com/jaredhanson/passport-google-oauth2/issues/64, but also may be related to some of the issues of that repo such as involving InternalOAuthError: Failed to obtain access token: https://github.com/jaredhanson/passport-oauth2/issues/155, https://github.com/jaredhanson/passport-oauth2/issues/113

blargism commented 1 year ago

This is a pretty critical issue. Can it please be prioritized? My only recourse right now is to fork and patch. Given the number or forks it seems many others have also done so.

Let me know if I or other community members can help.