search

jaredhanson / passport-oauth2

OAuth 2.0 authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-oauth2/?utm_source=github&utm_medium=referral&utm_campaign=passport-oauth2&utm_content=about
MIT License
607 stars 343 forks source link

Bump `oauth` from 0.9.x to 0.10.x #165

Closed Quentin-Danjou closed 9 months ago

Quentin-Danjou commented 2 years ago

This is solving issues of passport-google-oauth2 as stated in issue #163

ahmet commented 2 years ago

need this

TwistedLogic commented 2 years ago

Can you please merge this and release a new version? passport-spotify has issues.

Quentin-Danjou commented 2 years ago

@jaredhanson is there anything I can do so we can merge this?

fractallian commented 2 years ago

We need this as well 🙏

serniebanders commented 2 years ago

Please

pablomusumeci commented 2 years ago

Please, can we get this one merged? It would be extremely helpful 🙏

cjezinne commented 2 years ago

@jaredhanson can we get this merged?

cjezinne commented 2 years ago

@pablomusumeci Here's a fork by @serniebanders: "You can use this as a dependency: git+https://github.com/serniebanders/passport-google-oauth2.git"

pablomusumeci commented 1 year ago

@cjezinne thanks! Although, relying on an unofficial fork is not a future-proof solution 😢

rjenkin commented 1 year ago

For anyone else with this issue, I've found a workaround to force passport-oauth2 to use oauth@0.10.0 by adding an override into my project's package.json:

    "overrides": {
        "oauth": "~0.10.0"
    }

When the node_modules were deleted/reinstalled, passport-oauth2 was using version 0.10.0:

$ npm list oauth
server@1.0.0 /Users/.../webserver
└─┬ passport-oauth2@1.6.1
  └── oauth@0.10.0

Just keep in mind that this code should be removed if passport-oauth2 is ever upgraded in future to use a higher version of oauth, e.g 0.11.0 which currently doesn't exist.

pedrohma commented 1 year ago

@rjenkin you are the man

pedrohma commented 1 year ago

@jaredhanson please merge this PR

grigored commented 1 year ago

For anyone else with this issue, I've found a workaround to force passport-oauth2 to use oauth@0.10.0 by adding an override into my project's package.json:

    "overrides": {
        "oauth": "~0.10.0"
    }

When the node_modules were deleted/reinstalled, passport-oauth2 was using version 0.10.0:

$ npm list oauth
server@1.0.0 /Users/.../webserver
└─┬ passport-oauth2@1.6.1
  └── oauth@0.10.0

Just keep in mind that this code should be removed if passport-oauth2 is ever upgraded in future to use a higher version of oauth, e.g 0.11.0 which currently doesn't exist.

Thanks a lot for this fix! For yarn users, instead of overrides you should use resolutions. Also, if you are using yarn workspaces make sure to put this in the root package.json

jaredhanson commented 9 months ago

Merged and published as passport-oauth2@1.8.0. Thanks!