search

jaredhanson / passport-openid

OpenID authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-openid/?utm_source=github&utm_medium=referral&utm_campaign=passport-openid&utm_content=about
MIT License
98 stars 90 forks source link

Dependency on old passport is breaking code that uses newer passport. #28

Closed jdfm closed 8 years ago

jdfm commented 10 years ago

I was testing the LocalStrategy for a login page I was building and I was expecting to see the req object in the passport.serializeUser method, but it was never there, after some sleuthing I found that the version of passport that is being included with passport-openid is substituting the newer version of passport that I actually wanted to use. Code that is being used:

node_modules/passport-openid/node_modules/passport/lib/passport/http/request.js

Code that should be in current use instead:

node_modules/passport/lib/passport/http/request.js

filso commented 8 years ago

+1

jaredhanson commented 8 years ago

Published package with fix to npm as passport-openid@0.4.0.

filso commented 8 years ago

@jaredhanson could you also update package.json in passport-paypal to new version? https://github.com/jaredhanson/passport-paypal/blob/master/package.json#L25