Closed sreuter closed 8 years ago
Finally, tests are green :+1: !
@jaredhanson, any chance we can get this merged anytime soon? Cheers!
Btw, I highly recommend making this 0.4.0, as there might be regressions for some setups.
Can you list what the regressions might be?
Sent from my iPhone
On Aug 25, 2015, at 10:06 PM, Sascha Reuter notifications@github.com wrote:
Btw, I highly recommend making this 0.4.0, as there might be regressions for some setups.
— Reply to this email directly or view it on GitHub.
The custom http logic in node-openid has been replaced by using request instead. That could potential change behaviour on the redirect following strategy, proxy selection (NO_PROXY is now being honored!), etc.
I don't think there's much risk, but making this a 0.4.0 should make it clear that things should be tested after upgrading.
See also https://github.com/atlassian/node-openid/commit/d15ca09657ae986df8fd9fef09be7d65414ec407
@jaredhanson Do you have any open concerns with this?
@jaredhanson Would be great to hear if there's anything that prevents us from getting this in. This should make things regarding general openid/http handling much more robust and bullet-proof for the future.
Published passport-openid@0.4.0
to npm.
Awesome sauce, cheers @jaredhanson !
@sreuter legendary! :dancer:
This solves quite some issues with proxies and more. https://github.com/havard/node-openid/pull/135