Update package.json to use node-openid@1.0

jaredhanson / passport-openid

OpenID authentication strategy for Passport and Node.js.

https://www.passportjs.org/packages/passport-openid/?utm_source=github&utm_medium=referral&utm_campaign=passport-openid&utm_content=about

MIT License

98 stars 90 forks source link

Update package.json to use node-openid@1.0 #32

Closed sreuter closed 8 years ago

sreuter commented 9 years ago

This solves quite some issues with proxies and more. https://github.com/havard/node-openid/pull/135

sreuter commented 9 years ago

Finally, tests are green :+1: !

@jaredhanson, any chance we can get this merged anytime soon? Cheers!

sreuter commented 9 years ago

Btw, I highly recommend making this 0.4.0, as there might be regressions for some setups.

jaredhanson commented 9 years ago

Can you list what the regressions might be?

Sent from my iPhone

On Aug 25, 2015, at 10:06 PM, Sascha Reuter notifications@github.com wrote:

Btw, I highly recommend making this 0.4.0, as there might be regressions for some setups.

— Reply to this email directly or view it on GitHub.

sreuter commented 9 years ago

The custom http logic in node-openid has been replaced by using request instead. That could potential change behaviour on the redirect following strategy, proxy selection (NO_PROXY is now being honored!), etc.

I don't think there's much risk, but making this a 0.4.0 should make it clear that things should be tested after upgrading.

sreuter commented 9 years ago

@jaredhanson Do you have any open concerns with this?

sreuter commented 9 years ago

@jaredhanson Would be great to hear if there's anything that prevents us from getting this in. This should make things regarding general openid/http handling much more robust and bullet-proof for the future.

jaredhanson commented 8 years ago

Published passport-openid@0.4.0 to npm.

sreuter commented 8 years ago

Awesome sauce, cheers @jaredhanson !

mitermayer commented 8 years ago

@sreuter legendary! :dancer: