search

jaredhanson / passport-openidconnect

OpenID Connect authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-openidconnect/?utm_source=github&utm_medium=referral&utm_campaign=passport-openidconnect&utm_content=about
MIT License
188 stars 173 forks source link

add PKCE support #110

Open aaronpk opened 5 months ago

aaronpk commented 5 months ago

enable with pkce: true when creating the strategy.

Closes #83 and #56

kamronbatman commented 5 months ago

Great job, thank you!!

darknightdev commented 4 months ago

Great job! @kamronbatman We need this feature as well, can we please merge and publish? Thanks

kamronbatman commented 4 months ago

Waiting on @jaredhanson to validate, add tests, and determine if there are any breaking changes. It sounds silly but many people rely on this. If I get time next week I'll work with him on tests.

MattPaymentus commented 4 months ago

I tested this further. The call back on the backend doesn't pass the code challenge with it so it errors out.

aaronpk commented 4 months ago

@MattPaymentus not sure what you mean, I have this code working against an authorization server that requires PKCE.

quichef commented 3 weeks ago

Hello, we'd be interested on my side with this PR