jaredhanson / passport-openidconnect

OpenID Connect authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-openidconnect/?utm_source=github&utm_medium=referral&utm_campaign=passport-openidconnect&utm_content=about
MIT License
188 stars 173 forks source link

I can't get this to work because self._passport.session is undefined #14

Closed richtera closed 8 years ago

richtera commented 8 years ago

Is this maybe incompatible with a more recent passport version? The code in this repo (snippet of req.login)

    this._passport.instance.serializeUser(user, this, function(err, obj) {
      if (err) { self[property] = null; return done(err); }
      self._passport.session.user = obj;
      done();
    });

whereas the same kind of code (req.login) inside of passport lib/http/request.js

    this._passport.instance.serializeUser(user, this, function(err, obj) {
      if (err) { self[property] = null; return done(err); }
      if (!self._passport.session) {
        self._passport.session = {};
      }
      self._passport.session.user = obj;
      if (!self.session) {
        self.session = {};
      }
      self.session[self._passport.instance._key] = self._passport.session;
      done();
    });

Also why does this module have it's own req.login implementation? Not sure how to get past this.

richtera commented 8 years ago

Hmmm... actually something is reversed between the two... checking more might close this.

richtera commented 8 years ago

Figured it out. I had several different versions of passport in my various node_modules.