Allow for extending `. authorizationParams()`, uncomment support for options.state

jaredhanson / passport-openidconnect

OpenID Connect authentication strategy for Passport and Node.js.

https://www.passportjs.org/packages/passport-openidconnect/?utm_source=github&utm_medium=referral&utm_campaign=passport-openidconnect&utm_content=about

MIT License

190 stars 175 forks source link

Allow for extending `. authorizationParams()`, uncomment support for options.state #6

Closed gobengo closed 2 years ago

gobengo commented 9 years ago

I am using this library and found this changeset useful.

I subclassed strategy and overwrote #authorizationParams to specify prompt
I make use of .authenticate({ state }) to embed a destination redirect_uri in state

Are you accepting PRs? I can also make a PR to remove unnecessary console.logs. If you'd prefer a fork, I'll do that too.

kara-ryli commented 9 years ago

I was wondering if it made sense to pass req to #authorizationParams; this would allow you to specify prompt, ui_locales and login_hint based on properties of the request, which makes sense in my mind.

Also, I notice this library hasn't had a commit in 2 years, while passport-oauth2 has seen a bit more action. Given how similar the strategies are, would it make sense to have this one inherit from the other?

jaredhanson commented 2 years ago

The functionality in this PR has been implemented in the master branch at some point between now and when this PR was opened. Thanks, closing.