search

jaredhanson / passport-openidconnect

OpenID Connect authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-openidconnect/?utm_source=github&utm_medium=referral&utm_campaign=passport-openidconnect&utm_content=about
MIT License
191 stars 177 forks source link

feat: enable authorizationParams as defined within options #60

Closed bufferoverflow closed 2 years ago

bufferoverflow commented 6 years ago

This enables people to use passport-openidconnect directly when specific parameters are required instead of creating another passport strategy. A additional parameter can be passed within the authenticate method, e.g. passport.authenticate('openidconnect', {connection: 'my-oidc'})...

jaredhanson commented 2 years ago

I'm declining to merge this because it violates encapsulation. Not all options are valid parameters to send in an authorization request. This module parses options for valid params as defined by the OpenID Connect specification. Any other parameters are extensions that are (typically) specific to individual OpenID providers. Given that, encapsulating provider specific extensions in provider specific modules makes development and maintenance easier.