search

jaredhanson / passport-openidconnect

OpenID Connect authentication strategy for Passport and Node.js.
https://www.passportjs.org/packages/passport-openidconnect/?utm_source=github&utm_medium=referral&utm_campaign=passport-openidconnect&utm_content=about
MIT License
188 stars 173 forks source link

use arity of the user provided verify-function #88

Closed PatersonDjemi closed 2 years ago

PatersonDjemi commented 2 years ago

we are currently using the passport-openidconnect strategy for the authentication in node-red. Because node-red wraps the verify-callback in another function when creating the strategy, which has an arity of 0, our verify-callback always gets called with only three arguments. As result we can neither have access to the user's profile nor to the tokens.

Here is a link: https://github.com/node-red/node-red/blob/f1e7ec0c6bc33d4d0f6286012ef4d5aa817ac0b5/packages/node_modules/%40node-red/editor-api/lib/auth/index.js#L177-L196

dschmidt commented 2 years ago

We are trying to get this fixed in node-red directly instead now: https://github.com/node-red/node-red/pull/3117

dschmidt commented 2 years ago

Fixed in https://github.com/node-red/node-red/pull/3117

This can be closed imho.