jaredhanson / passport

Simple, unobtrusive authentication for Node.js.
https://www.passportjs.org?utm_source=github&utm_medium=referral&utm_campaign=passport&utm_content=about
MIT License
22.94k stars 1.24k forks source link

New strategy available: passport-negotiate implementing Negotiate (kerberos/SPNEGO) #408

Open dmansfield opened 9 years ago

dmansfield commented 9 years ago

The passport-negotiate module is now available which implements Negotiate (kerberos/SPNEGO) authentication. Can it be added to the "available strategies" page on the main passport website?

npm: https://www.npmjs.com/package/passport-negotiate github: https://github.com/dmansfield/passport-negotiate

jaredhanson commented 9 years ago

Instead of depending on passport@2.0.0, can you depend on passport-strategy? That's important for compatibility with newer versions of Passport, including 0.3.x and on.

dmansfield commented 9 years ago

Is there a specific version I should target?

jaredhanson commented 9 years ago

Just inherit from passport-strategy:

https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L4 https://github.com/jaredhanson/passport-oauth2/blob/master/package.json#L35

jaredhanson commented 9 years ago

Passport strategies should not depend on Passport core. They should only depend on passport-strategy.

dmansfield commented 9 years ago

v0.1.3 has been published with this change. I have re-tested with the included "login" example app.

dmansfield commented 9 years ago

Hey Jared. Dependencies have been fixed as per your suggestions. Any other comments regarding the module? Any chance to add it to the "strategies" section on the site?

zckrs commented 8 years ago

Hi I try to use passport-negotiate. But I would know if this module is maintained.

dmansfield commented 8 years ago

Yes, it is maintained. Unfortunately the underlying module for kerberos doesn't support windows at this time - that is the only known issue. If you have any issues please feel free to add them to the issue tracker for the repository: https://github.com/dmansfield/passport-negotiate