jaredhendrickson13 / pfsense-api

The missing REST and GraphQL API package for pfSense
https://pfrest.org/
Apache License 2.0
688 stars 105 forks source link

API for captive portal status #62

Open ghost opened 3 years ago

ghost commented 3 years ago

Can you add an end point to get captive portal status. Thank you.

jaredhendrickson13 commented 3 years ago

Hey!

Thanks for the request. I'll do some research and see what this would take. I'll provide an update when I've had a chance to take a look.

Thanks again!

ghost commented 3 years ago

Can you point me to resources where I can learn and start building stuff like these myself. Thank you.

jaredhendrickson13 commented 3 years ago

You can refer to the contributors guide to learn the framework and start building your own API endpoints. You may also use the existing code as reference for your code.

It helps to have a good understanding of the pfSense code, PHP, and FreeBSD 11/12. You can refer to these documents:

If you plan on merging your code into this project, you should also have a good understanding of Python3 to write unit tests as well as REST architecture:

tjsas1 commented 3 years ago

Will this include Vouchers and allowed mac and ip?

jaredhendrickson13 commented 3 years ago

@tjsas1 the work I have staged for this particular feature will only include data found under Status > Captive Portal within the UI. I believe the data you are referring to is found under Services > Captive Portal, which would need to be factored into a separate endpoint. If that is a desired feature, feel free to open a feature request and I'll see what I can do.

lmjaromay commented 1 year ago

@jaredhendrickson13 Any news on this? we are actually eyeing to do a few automations in the vouchers and this api has been of really great help.