Include user reply in notification callback

jaredks / rumps

Ridiculously Uncomplicated macOS Python Statusbar apps

BSD 3-Clause "New" or "Revised" License

3.09k stars 179 forks source link

Include user reply in notification callback #122

Closed davea closed 4 years ago

davea commented 5 years ago

When showing a notification with has_reply_button=True, the user's reply is now included in the dict passed to the @rumps.notifications handler in the response key.

Also fixes a crash due to data not always being initialised properly in userNotificationCenter_didActivateNotification_.

Fuchida commented 5 years ago

Just ran into this crash, hopefully it can be tested and merged

davea commented 5 years ago

As a workaround until this is merged, you can pass data={} when calling rumps.notification.

davea commented 4 years ago

Closing for my own peace of mind when looking at https://github.com/pulls :)