$ python test_notifications.py
Traceback (most recent call last):
File "test_notifications.py", line 2, in <module>
rumps.notification('a', 'b', 'c', data='string data')
File "rumps/rumps.py", line 171, in notification
raise TypeError('notification data must be a mapping')
TypeError: notification data must be a mapping
Not exactly an error but an unnecessary restriction since changing to serializing provided data.
$ python test_notifications.py
Traceback (most recent call last):
File "test_notifications.py", line 2, in <module>
rumps.notification('a', 'b', 'c', data={2: 22})
File "rumps/rumps.py", line 182, in notification
app = getattr(App, '*app_instance')
AttributeError: type object 'App' has no attribute '*app_instance'
Again, not an error but we don't need to have an instance to just use the default serializer on the class (pickle). This is also not a particularly helpful error.
2020-03-13 22:16:04.707 Python[57808:6820751] -[OC_BuiltinPythonData fastestEncoding]: unrecognized selector sent to instance 0x7fc3107598f0
rumps/rumps.py:185: UninitializedDeallocWarning: leaking an uninitialized object of type NSPlaceholderString
ns_string = NSString.alloc().initWithString_(dumped)
This happens on Python 3 because pickle returns bytes which cannot be turned into NSString directly.
Fixes https://github.com/jaredks/rumps/issues/126
master
Issue 1
Not exactly an error but an unnecessary restriction since changing to serializing provided data.
Issue 2
Again, not an error but we don't need to have an instance to just use the default serializer on the class (
pickle
). This is also not a particularly helpful error.Issue 3
Run, then click "test" menu item,
This happens on Python 3 because
pickle
returnsbytes
which cannot be turned intoNSString
directly.Issue 4
Run, then click "test" menu item, then click the notification that is created,
This branch
Issue 1
No errors, notification works.
Issue 2
No errors, notification works.
Issue 3
No errors, notification works.
Issue 4