search

jaredks / rumps

Ridiculously Uncomplicated macOS Python Statusbar apps
BSD 3-Clause "New" or "Revised" License
3.09k stars 179 forks source link

Update README.rst #217

Closed piotr-szewczuk closed 1 week ago

piotr-szewczuk commented 2 weeks ago

Fix example app to work on macOS Sequoia.

@daredoes

piotr-szewczuk commented 2 weeks ago

From what I can see now removing space in "Awesome App" string would also worked :)

SKaplanOfficial commented 2 weeks ago

The current example works fine for me on Sequoia. What issue are you having? Also, manually calling super.__init__() is redundant, as is setting self.menu since the @rumps.clicked decorator adds menu items if they don't exist yet.

piotr-szewczuk commented 2 weeks ago

Hi,

on my machine running current example doesn't work. Nothing appears on the menu bar. My PR is just modified version of example from:

https://rumps.readthedocs.io/en/latest/examples.html.

But as I stated in comment problem was not with lack of init but with space in "Awesome App" title. I can edit PR to just something like:

AwesomeStatusBarApp("Awesome_App").run()

but if this example, with space works for you than probably something else is wrong on my site :/

SKaplanOfficial commented 2 weeks ago

Hm, both the example on GitHub and the one on readthedocs work the same for me. Not sure why the one on readthedocs has redundant lines.

Not sure what the issue on your end might be. Do you use a menubar manager like Ice or Bartender?

piotr-szewczuk commented 2 weeks ago

I used Bartender some time ago but not anymore... Probably it's time for clean system install :/

I can close PR if problem is only on my site only. BTW thx for this lib, it's pretty cool!

Cheers :)