search

jaredledvina / ledvinafarm-site

Holding all things hosted on https://ledvina.farm
2 stars 0 forks source link

Email link is broken #4

Open tlcowling opened 7 years ago

tlcowling commented 7 years ago

When I click the email link at the bottom of each page, the link appears to just be #

Please don't make it a mailto:

Ideally I'd like to see some fancy animated CSS3 style megaform flying through the sky...

Also did you give any consideration to the autobots out there that might try to scrape your email ? fyi I'm hardly one to talk I plaster my email everywhere.

Thanks for your time.

jaredledvina commented 6 years ago

@tlcowling - Would you be willing to PR what you want for this issue?

tlcowling commented 6 years ago

Still working on this; I had to refactor your code, it was extremely important. I've abstracted the concept of communication so that we can, in the future, enable new communication strategies that we don't even know about yet. We can only hope that someone doesn't decide to refactor the code I've written... The line must be drawn somewhere and I say its at re-refactoring.

Of additional importance to me was that this comment directly addressed the points most relevant to this issue and self evidently it has.

Thanks for your time.