search

jaredleekatzman / DeepSurv

DeepSurv is a deep learning approach to survival analysis.
MIT License
584 stars 173 forks source link

required Theano version #19

Open baharian opened 6 years ago

baharian commented 6 years ago

Is it absolutely necessary to have Theano 0.8.2 to properly run DeepSurv? Would DeepSurv fail to function if the Theano version is different from 0.8.2? Installing DeepSurv rolls back my Theano to an older, outdated version.

dareneiri commented 6 years ago

I haven't used the latest DeepSurv version that just got updated, but I used the previous version (a few weeks ago) and I'm running Theano 0.10.0b1, lasagne 0.2.dev1 without any conflicts on deepsurv.

baharian commented 6 years ago

Thanks! I'll just update my Theano back to the new version then.

baharian commented 6 years ago

Would it break DeepSurv if >= is used, as follows,

install_requires=[
        'theano>=0.8.2',
        'lasagne==0.2.dev1',
        'lifelines>=0.9.2',
        'tensorboard_logger==0.0.3'
]

instead of == in setup.py so installing DeepSurv doesn't overwrite the existing Theano and lifelines packages?

dareneiri commented 6 years ago

I've done something very similar and haven't had any issues.

What I usually do is first install deepsurv, and then manually install theano/lasagne with the bleeding edge version (see their site's documentation) to avoid any issues with theano not installing correctly.

TeaPearce commented 6 years ago

Been working fine with version 0.9.0 for me