search

jaredleekatzman / DeepSurv

DeepSurv is a deep learning approach to survival analysis.
MIT License
566 stars 166 forks source link

hyperparameter_search.py script giving error: TypeError: 'NoneType' object is not callable #61

Open quzhouxiachuan opened 4 years ago

quzhouxiachuan commented 4 years ago

I slightly modified the hyperparameter search script so it can be used without using docker. I tried to run random search with different optimizers. My script works fine when using Adam as update_fn.

However, when using adadelta, it shows the following error: OMP_NUM_THREADS=10 python hyperparam_search_test.py ./ /home/ydw529/DEEPLEARNING/code/deepsur_dneg/DeepSurv/hyperparam_search/box_constraints.0.json 50 --num_epochs 500 --update_fn "adadelta"

File "/home/ydw529/.conda/envs/theano/lib/python3.8/site-packages/deepsurv/deep_surv.py", line 211, in _get_loss_updates updates = update_fn( TypeError: 'NoneType' object is not callable

I am wondering if anyone had the same issue before? If so, how did you solve it? Much appreciated!

jaredleekatzman commented 3 years ago

Are you still facing the issue?

This is because the 'adadelta' updater isn't implemented in the utils function: here. So the function is returning "None".

If you can update the utils function with the correct code and send a PR, I would be happy to merge it!