jaredlhf / pe

0 stars 0 forks source link

Diagram for deleteStudent is unnecessary #7

Open jaredlhf opened 2 years ago

jaredlhf commented 2 years ago

Screenshot 2021-11-12 at 5.28.09 PM.png

students followed by deleteStudent 1 removes the 1st student in the students list.

the intentions of the diagram could not be seen in the diagram itself.

Might also confuse the readers as they are unsure deleteStudent 1 will delete Bernice Yu or deleteStudent 1 has already deleted someone

nus-pe-bot commented 2 years ago

Team's Response

The diagram is used to show the output status message, and to show that the first student in the list has indeed been deleted.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: * Im still unsure how the diagram shows "that the first student in the list has indeed been deleted."

Screenshot 2021-11-17 at 1.03.41 AM.png

Screenshot 2021-11-17 at 1.07.04 AM.png