jaredlll08 / Controlling

Gives you more control over the Keybindings menu
MIT License
58 stars 39 forks source link

Feature: Allow double interactions #77

Open ShootToKillSTK opened 3 years ago

ShootToKillSTK commented 3 years ago

Enable the use of things like 'shift + e' 'alt + b' etc.

Normally that will work, but if you also use e for something, and just press e, it will do both of them );

Or is this a thing of this mod? Sorry if so but it doesn't say so, feel like it would if so

There link: https://www.curseforge.com/minecraft/mc-mods/amecs Would be an amazing feature for all modpack makers on forge version, like myself!

jaredlll08 commented 3 years ago

I'm so confused by this issue.

Controlling just changes the screen, not how keybinds function / are triggered.

I'm also not sure what you mean by:

Or is this a thing of this mod? Sorry if so but it doesn't say so, feel like it would if so

  • I see only mods for lower versions or there is a only fabric one I believe wit this, for 1.16.4/5 only
  • They allow porting to forge

but Controlling is a Forge mod. There is Controlling for Fabric however.

egeesin commented 2 years ago

I think I have the similar issue.

Assuming we're discussing about Fabric version of Controlling mod since you merged the project, I think what he/she meant is, with Amecs mod you're able to create keybinds like specific combos/keystrokes/macros etc. where you can't in vanilla. But if you use Amecs and Controlling together, you aren't able to create new keybindings like Left Control+S, Shift+Control etc. If you try to do that, it only binds the first modifier key (Control, Shift). The only bright side is Controlling doesn't meddle with existing key combos unless you try to edit.

As far as I tested, only workaround is to disabling Controlling temporarily, making keybinds with Amecs enabled on (like Ctrl+?, Shift+?) then enabling Controlling back.

I love the both mods with the things that provides the player much more power to control and giving useful info about it and I hope there will be compatibility between the mods.

P.S. You can change the title as "Unable to make key combos with Amecs." for helping the people who have similar specific issue.

jaredlll08 commented 2 years ago

Assuming we're discussing about Fabric version of Controlling mod since you merged the project

At the time that this issue was made, this repository was only for Forge. This has changed since then.

So I'm open adding support for it if Ameks is installed, but I'm not exactly sure about how to go about doing that.

@Siphalor any chance you would be open to discussing how we can glue the mods together?

Alternatively I could just make it that if you hold shift while opening the keybinds screen it opens the vanilla one, which should work, but would not be ideal.

AlisterGontineac commented 2 years ago

You can still add multi-key modifiers with an earlier version on fabric "Controlling-For-Fabric-1.2.0.jar" { https://www.curseforge.com/minecraft/mc-mods/controlling-for-fabric/files/3331405 )

ajaxnotmeta commented 2 months ago

why this also hapens on NeoForge 1.20.1?

jaredlll08 commented 2 months ago

Check if you can reproduce without controlling, it is very possible that neoforge itself is broken, I had to make a PR to fix it on 1.21, but I don't know what version it actually broke on.

ajaxnotmeta commented 2 weeks ago

Check if you can reproduce without controlling, it is very possible that neoforge itself is broken, I had to make a PR to fix it on 1.21, but I don't know what version it actually broke on.

1.21 seems fine, but 1.20.1 both neoforge and lexforge suffers the same bugs

jaredlll08 commented 2 weeks ago

I just tested using Forge on it's own, and with Controlling and I cannot reproduce any bugs with setting double interactions on 1.20.1.

I also tested with Neoforge on it's own (no Controlling version for 1.20.1 neoforge), and also can't reproduce any bug.

If you are experiencing a bug, make sure you are on the latest version of everything.