jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
69 stars 63 forks source link

[Bug][Compat] Thaumcraft additional aspect #645

Closed drakray closed 6 years ago

drakray commented 6 years ago

Issue Description:

I can't use aspect from other mod than Thaumcraft in setAspect, namely Tempus and Spatium from Planar Artifice. Ingame, before restarting with the script, /ct syntax say everything is ok, and /ct thaumcraftdump list Tempus and Spatium as valid aspect.

What happens:

crafttweaker.log says "Could not resolve " and a bunch of Bytecode.

What you expected to happen:

To add Tempus and/or Spatium to items/blocks

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

14-ThaumcraftPlanar.zs

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):

https://www.dropbox.com/s/jbrtyu69gs41vbh/crafttweaker.log


Affected Versions (Do not use "latest"):

Your most recent log file where the issue was present:

https://www.dropbox.com/s/jbrtyu69gs41vbh/crafttweaker.log

Relevant line: l#526 : Could not resolve l#7003 : ThaumcraftDump start l#7249/50 : Aspect from Planar Artifice l#8737-8779 : /ct syntax with no error

/ct hand on Spatium Vis crystal : .withTag({Aspects: [{amount: 1, key: "Spatium"}]}), note the capital on key, hence why I tried capitalizing Spatium

kindlich commented 6 years ago

I could've sworn there was an issue template that tells people to post more information on what is not working as well as a logs, a simple script, MC info and the like.

drakray commented 6 years ago

sorry, i'll fix that when I get the necessary info, in a couple of minute

drakray commented 6 years ago

OP fixed, I hope everything is in order

drakray commented 6 years ago

strangely, near line 525, script is loaded with "Could not resolve", but Print Out are not

jaredlll08 commented 6 years ago

so whatever mod is adding that aspect, is adding it after our scripts are ran, so it doesn't exist as script compile time, I'm sorry but there isn't a fix for this :(

drakray commented 6 years ago

Yeah that's what I thought, I'm moving that to Planar Artifice, asking if they can register their aspect sooner

Geethebluesky commented 6 years ago

@jaredlll08 changing mod load order doesn't fix this?

jaredlll08 commented 6 years ago

Nope, there are different loading stages, we run our scripts early, authors are adding aspects later.

On Sun, May 27, 2018, 23:49 Gee notifications@github.com wrote:

@jaredlll08 https://github.com/jaredlll08 changing mod load order doesn't fix this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jaredlll08/ModTweaker/issues/645#issuecomment-392379611, or mute the thread https://github.com/notifications/unsubscribe-auth/AFS9xcHtCHDEP0sUAM_BPdrOehUJeAybks5t2x9PgaJpZM4UHgHG .

drakray commented 6 years ago

@jaredlll08 is preinit soon enough to register aspect? Thaumic Addition Reconstructed add some aspect in preinit. I can't test it for now, but with it's next version I will.

jaredlll08 commented 6 years ago

Anything before Register is good

On Sun, May 27, 2018, 23:53 Raymond Tremblay notifications@github.com wrote:

@jaredlll08 https://github.com/jaredlll08 is preinit soon enough to register aspect? Thaumic Addition Reconstructed https://github.com/Zeitheron/ThaumicAdditions/blob/be39462da20bb6309d15dd1e10c3f0afba01e89c/src/main/java/com/zeitheron/thaumicadditions/TAReconstructed.java add some aspect in preinit. I can't test it for now, but with it's next version I will.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jaredlll08/ModTweaker/issues/645#issuecomment-392379865, or mute the thread https://github.com/notifications/unsubscribe-auth/AFS9xV-xhAmYrA67auscWaU8nmAFd39vks5t2yBJgaJpZM4UHgHG .

drakray commented 6 years ago

oki, thanks :D