search

jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

add methods for forestry ICharcoalManager #678

Closed temp1011 closed 5 years ago

temp1011 commented 6 years ago

There is a forge version and forestry version bump needed for this to work but I'm not sure what the best way to integrate that is. Specifically forge must be at least 14.23.4.2749 and forestry needs to be 5.8.1.341.

I'm not too experienced with writing stuff for zenscript so let me know if I've done anything wrong.

temp1011 commented 6 years ago

Hopefully everything should be fixed up now. My initial code was definitely quite bad!

kindlich commented 6 years ago

Looks good to me now. Did you test your methods and if yes, care to provide an example script so that I have something to eventually add to the wiki?

temp1011 commented 6 years ago

I used the small test added, it's not great but tests basic coverage. I'm happy to add more if needed.

jaredlll08 commented 6 years ago

Can you add a method that takes an IItemStack and then converts that stack to a block, like the botania pure daisy