jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

[Bug] Editing ArcaneWorkbench recipes breaks Thaumonomicon #682

Closed noobanidus closed 6 years ago

noobanidus commented 6 years ago

Issue Description:

It's not possible to modify a recipe referred to in the Thaumonomicon without "deleting" the recipe from the book (most specifically the list of recipes unlocked by the specific research found on the right hand side of the page).

What happens:

Removing the Thaumometer recipe and recreating it with the first parameter set to "thaumcraft:thaumometer" prevents it from being displayed in the relevant Thaumonomicon tab, as the tab is specifically looking for "thaumcraft:thaumometer" but registerShapedRecipe and registerShapelessRecipe modify the recipe name to "modtweaker:thaumcraft:thaumometer".

As you can see from the research json asset (https://pastebin.com/i82pqZwP) , the stages of this research snippet are specifically looking for "thaumcraft:thaumometer".

What you expected to happen:

The relevant functions not to modify the name of the recipe.

Theoretically it would be as simple as changing it to "ResourceLocation(name)" instead of "ResourceLocation(MODID, name)" but I'm not sure what implications this would have for a recipe without a namespace.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

https://pastebin.com/1FmjW3Un

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):


Affected Versions (Do not use "latest"):

Your most recent log file where the issue was present:

[pastebin/gist/etc link here]