search

jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

Latest TE 5.5.1.33 appears to have broke removing induction smelter recipes (possibly more) with CraftTweaker #692

Closed tgstyle closed 5 years ago

tgstyle commented 5 years ago

Issue Description:

I have tried my script to remove them both ways even in succession. There is no error in the CT log, it even shows it removed them both ways, yet they still process in the machine and show in JEI.

What happens:

Nothing is removed

What you expected to happen:

Items in the script to be removed

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will https://gist.github.com/tgstyle/d3dfba1c25f373807a5f5180f2951f78

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will

https://gist.github.com/tgstyle/d95356169932fbc250e023835b56c643

Affected Versions (Do not use "latest"):

https://github.com/CoFH/Feedback/issues/1308

tgstyle commented 5 years ago

With the latest TE 5.5.2.39 and this PR in a custom build, plus having to put wildcards for meta where previously was not needed, seems to have fixed it. https://github.com/jaredlll08/ModTweaker/pull/686

noobanidus commented 5 years ago

It does appear to be something to do with the conversion of ItemStacks into the comparable ones that are used by CoFH. As in, the issue is that getRecipe does a lot of work to find the right combination of comparable item stacks, but removeRecipe doesn't.

noobanidus commented 5 years ago

I believe this is an issue with ThermalExpansion and not ModTweaker. I've opened an issue with CoFH, and hopefully it can be resolved from that end.

jaredlll08 commented 5 years ago

This was either fixed by a PR, or I can't reproduce.