search

jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

Melting.removeRecipe cannot be used to remove recipes that use the ore dictionary. #713

Closed ErzengelLichtes closed 5 years ago

ErzengelLichtes commented 5 years ago

Issue Description:

The Tinker's Construct Melting.removeRecipe sets the "input" as an IItemStack rather than an IIngredient that's used by Melting.addRecipe, preventing the removal of recipes that use Ore Dictionaries. For example, is used to make glass, so you cannot remove the recipe.

What happens:

You get an error when you try to use an ore dictionary.

What you expected to happen:

The recipe to create the liquid from the ore dictionary item will be correctly removed.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

https://pastebin.com/qtcwqqJV

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):

https://pastebin.com/BHGhmSDY

Affected Versions (Do not use "latest"):

Your most recent log file where the issue was present: [pastebin/gist/etc link here]

https://pastebin.com/rwjvW1Xt

jaredlll08 commented 5 years ago

There is no way to remove by OreDict, since TIC asks for a list of ItemStacks, but they have checks for oredict, aslong as the item is in an oredict, it should work, if it doesn't, report to TIC.