search

jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

added Immersive Tech support #735

Closed SanAndreaP closed 4 years ago

SanAndreaP commented 5 years ago

PS: I've added Immersive Tech to the libs folder manually, as when I tried to use the maven link, gradle errors with a ZipExeption upon setupDecompWorkspace

jaredlll08 commented 5 years ago

Why are you adding the jar file for immersive tech when you have the curseforge maven?

Why are you adding the CurseForge maven? IE is hosted on my maven (only new maven dep you added)

https://maven.blamejared.com/blusunrize/ImmersiveEngineering/

SanAndreaP commented 5 years ago

I've added the PS on why the jar file in the above comment

I didn't know that IE is hosted on your maven, I'll fix that.

kindlich commented 5 years ago

There is already a PR for ImmersiveTech to add CrT support on their end. Maybe there would be a better fit, maybe you can help them out there as well?

Also, since the ZenClass annotations have the same name argument, if both were to be added there would be conflicts, so keep that in mind as well.

The PR on their end: https://github.com/FerroO2000/Immersive-Tech/pull/84

SanAndreaP commented 5 years ago

The problem with that PR is that it's not only adding CT support, but is also reworking some of the machines and stuff.

Also their github is outdated as of now (the github version is 1.3.9, from around a year ago, whereas CurseForge has 1.3.10), so their PR most likely won't be merged anytime soon.