jaredlll08 / ModTweaker

ModTweaker is an addon for CraftTweaker, which provides Integration for an amount of mods.
MIT License
68 stars 63 forks source link

Thaumcraft 6 Thaumonomicon do not reflect current recipe #784

Closed Shazuli closed 2 years ago

Shazuli commented 2 years ago

Issue Description:

When you change a recipe in Thaumcraft the Thaumonomicon does not reflect the change. And if you remove the old recipe the recipe disappears from the book.

Before

2022-01-19_09 39 12

2022-01-19_09 38 56

After

2022-01-19_09 55 40

Recipe for the Thaumometer is not there anymore 2022-01-19_09 53 52

What you expected to happen:

The recipe change reflected as seen in JEI. Perhaps a function to override rather than remove and replace a recipe, or maybe a function to update the recipe visible in the book.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

https://pastebin.com/SsBwSCna


Affected Versions (Do not use "latest"):

kindlich commented 2 years ago

That would only work, if the recipe name stayed the same. But since you created a new recipe, it would create the recipe in the CrT namespace.

In older versions (1.7) you were able to modify thaumonomicon entries. I don't know how Thaumonomicon entries are handled in 1.12, you could see if you can change the recipe id via a resource pack or something?

jaredlll08 commented 2 years ago

1.12 has no thaumonomicon support, you will need to use a different mod for that, which I believe does exist.

Also recipes are registered under the "thaumcraft" namespace, so if you do it with the same name, it should show the new recipe.

Shazuli commented 2 years ago

@jaredlll08 I've been looking a bit in the wiki, but I can't find any mentions of registering a recipe in a different namespace. I also tried searching "Thaumcraft 6 recipe changer" into Google and did not get any matches. You think you could explain how to register a recipe in a different namespace?

jaredlll08 commented 2 years ago

You think you could explain how to register a recipe in a different namespace?

You don't.

We hardcoded it to the "thaumcraft" namespace.

It was an oversight at the time, and can't really be fixed now.

Vapaman commented 2 years ago

https://www.curseforge.com/minecraft/mc-mods/thaumcraft-research-patcher