jaredlll08 / MultiLoader-Template

A template for a Forge + Fabric project setup using a Common source set.
Creative Commons Zero v1.0 Universal
374 stars 73 forks source link

Parchment mappings #13

Closed lukebemish closed 4 months ago

lukebemish commented 2 years ago

Currently, parchment mappings cannot be used on MultiLoader-Template, as the Common project uses vanillagradle, which only supports mojang mappings. This means that when, for instance, navigating code in IntelliJ, code in the Common part will link to the normal, mojmaps-without-parameter-names mappings, even if the Forge or Fabric buildscripts are changed to use parchment. This could be fixed by switching the Common setup to use loom, though I am not sure what other routes might be possible. I do know that there is currently a pull request draft for mapping support open on vanillagradle, but I am not sure what the timeline looks like for that.

jaredlll08 commented 2 years ago

Assuming it is the same PR, https://github.com/SpongePowered/VanillaGradle/pull/47

If I recall correctly, the devs behind it are currently busy with other things unfortunately.

I currently use https://plugins.jetbrains.com/plugin/17485-scribe, which does help a bit for parameter names, although I do recognize it isn't a solution.

As for moving common to loom, we don't have any current plans to move away from VanillaGradle (it does exactly what we need and does it well), you of course can make the move to loom yourself in your own project (also look into QuiltFlower if you do, I've heard it is rather good), but right now, the most we may do is add a branch or an example for loom as common.

jaredlll08 commented 2 years ago

This issue may be relevant to you to get parchment mappings, although it is currently not a fully working solution https://github.com/jaredlll08/MultiLoader-Template/issues/17

lukebemish commented 2 years ago

I've already gotten loom working in common; I can put my solution in that issue though, if it wasn't already working

artemisSystem commented 4 months ago

Can this be closed now, since common uses ModDevGradle with NeoForm now?