search

jaredlll08 / TipTheScales

Allows for more options when adjusting the GUIScale option as well as making it a slider.
GNU Lesser General Public License v2.1
8 stars 6 forks source link

Make it compatible with Sodium #19

Closed Trackhe closed 1 year ago

Trackhe commented 2 years ago

Sodium needs also a fine slider. Would be cool if the mod add that posibillity

Gabo075 commented 2 years ago

Yes please, we need that

jaredlll08 commented 2 years ago

not sure I really understand the issue, sodium already has a slider?

image

There is an issue where they cap it at 4 though, but they have their own PR open for that, so what is actually being asked here?

ChristopherHaws commented 2 years ago

I think they are actually referring to Reese's Sodium Options: https://modrinth.com/mod/reeses-sodium-options Reese's sodium options causes the slider to jump in increments of 1 instead of letting you set it to fractions.

jaredlll08 commented 2 years ago

I think it would be better to request that they move to a slider themselves, won't be a fun time if I use a hacky workaround to make their button a slider and then they make it a slider themselves, no idea what would happen, maybe nothing, maybe a crash.

Gabo075 commented 2 years ago

not sure I really understand the issue, sodium already has a slider?

image

There is an issue where they cap it at 4 though, but they have their own PR open for that, so what is actually being asked here?

No, im guessing the the problem he refers to does not come with the slider that the sodium GUI brings. Instead it to the limited 5x options of the GUIScale of which one is "auto", so technically only 4x. Your mod adds 7x options for the GUI scale, not counting the "auto", allowing to adjust more depending on the screen. It would be great if there was more options for it in the sodium GUI.

jaredlll08 commented 2 years ago

In that case, there is this open PR for sodium: https://github.com/CaffeineMC/sodium-fabric/pull/1013

My mod just adds all the available options, sodium arbitrarily limits it to 4 for no reason, with vanilla you get the full 7-8

Trackhe commented 2 years ago

It exist a mod for optifine where you can scale like step less. Like a smooth slider with many steps. Like 3.4 or 3.35 are possible so. I can link them if needed.

jaredlll08 commented 2 years ago

And that is not something that I want to do with the mod right now, it needs way more investigation into how to do it correctly, and make sure it works with other mods (minecraft stores the scale as an int, not a double, so no decimals)

jaredlll08 commented 1 year ago

I'm going to be closing this due to it not actually being an issue or a feature request that I can reasonably implement.