Approval system fails to recognize users that have already been approved

[jaredlyon]

Current code:

if (msg.channel.id == bot.config.welcomeChannel) {
            if (target != null) {
                if (!target.roles) {
                    var logEmbed = new Discord.MessageEmbed()
                        .setAuthor(msg.author.username, msg.author.avatarURL())
                        .addField('Member approved:', yup + ` **${target.username.toString()}#${target.discriminator} (${target.id}) was approved.**`)
                        .setFooter(bot.user.username, bot.user.avatarURL())
                        .setTimestamp()
                        .setColor(3447003);

                    msg.mentions.members.forEach(member => {
                        member.roles.add(msg.guild.roles.cache.find(role => role.name === "• Customers")).then(member => {
                            channel.send({
                                embed: logEmbed
                            })
                            log.send({
                                embed: logEmbed
                            })
                        });
                    })
                } else if (target.roles) {
                    msg.reply("user has already been approved!");
                } else {
                    msg.reply("something went wrong!");
                }

Executed properly, the targeted user should not trigger the primary if statement due to their roles.

[jaredlyon]

Attempts to remedy the issue using a .cache.get method to probe the target user for a specific role have been unsuccessful due to (presumably) an inability to prompt a cache refresh. Specific code examples with attached error logs may be attached to the thread at a later time.

[jaredlyon]

Discord.js v12 includes an update to presence and server member intents, so this issue may resolve itself on its own with minor tweaks. See issue #30 for more info.

[jaredlyon]

Updated the if statements used in commit ca9c6b2, but now we're getting this really weird kickback error that has no discernable cause:

[jaredlyon]

I ended up removing the role check entirely (1d87462); if duplicate logs become a problem then we'll revisit this issue in the future.

[jaredlyon]

It appears the same issue has also broken the j!ban command in moderation:

[jaredlyon]

Verified the above commit's (9c7e1ef) fix:

I'll try it for the original j!approve command next.

[jaredlyon]

Commit 35117e3 recreates the original undefined cache error throw:

[jaredlyon]

Fixed by 74d3189:

The problem was that I had been using .users instead of .members...