jaredmcneill / quartz64_uefi

EDK2 UEFI for Rockchip RK3566 and RK3568 based SBCs.
153 stars 61 forks source link

RK356x: combine Gmac interrupts into single statement #58

Closed Manawyrm closed 7 months ago

Manawyrm commented 1 year ago

Hi,

I was playing around with the Gmac on Linux today and have seen some rather interesting behaviour. First of all: I'm not very well informed about ACPI internals (yet), so I have no real idea what I'm doing here.

It seems that Linux can't understand the 2 separate Interrupt() resource templates in the Gmac.asl file. As soon as I've combined these into a single statement, the kernel would resolve the 2 interrupts "macirq", "eth_wake_irq" successfully.

I'm not sure if this change has negative impact on other OSes.

As far as Linux is concerned, the current stmmac driver is not well equipped to handle configuration via ACPI. There's an open patchset from late last year, which tried to implement probing via the fwnode interface: https://lore.kernel.org/netdev/Y0VkeSxv9IkJPHJj@lunn.ch/T/ which should allow for configuration via ACPI/fwnode, but as far as I can tell, no such change was ever merged upstream.

What do you think?