jaredonline / google-authenticator

Ruby gem to implement Google's MFA authenticator
MIT License
307 stars 84 forks source link

unable to delete mfa cookie on production #93

Closed ccastillop closed 6 months ago

ccastillop commented 1 year ago

Hello, When calling UserMfaSession.destroy the mfa_credentials cookie is not destroyed at all.

It seems the GoogleAuthenticatorRails.destroy method requires the current domain as specified on https://api.rubyonrails.org/classes/ActionDispatch/Cookies.html

I will send a PR for that

alfie-max commented 12 months ago

if you're using cookies the method to be used to delete the cookie is via UserMfaSession::destroy. right?

jaredonline commented 12 months ago

Yep!