Fix getting false positives when using Cypress v5+ native retries

jaredpalmer / cypress-image-snapshot

Catch visual regressions in Cypress

MIT License

888 stars 160 forks source link

Closed lmeikle closed 3 years ago

lmeikle commented 3 years ago

When using native retries that come in Cypress v5+ real image failures are marked as passed on the retries.

This is because cypress names the snapshots as 'filename (attempt X).png (and there is no configuration option to change this)

The fix just removes the ' (attempt X)' suffix from the filename

VicJer commented 3 years ago

Can we get that in please?

omertalmi5 commented 3 years ago

Can you merge it please? It is very helpful @jaredpalmer

GalDayan commented 3 years ago

Hey, I will be happy if this PR will be merged

gilad207 commented 3 years ago

I hope it will be merged soon. very important fix

idomarko98 commented 3 years ago

Seems like this PR can hold great value, can you merge it, please?

albert-schilling commented 3 years ago

przemuh commented 3 years ago

Big, big, big, +1 👏

flavianh commented 3 years ago

Please @jaredpalmer could you merge this?

isaac-jordan commented 3 years ago

Any chance of an npm release based on this? Would be nice since it's a pretty big thing for Cypress v5 support.

jaredpalmer commented 3 years ago

Can cut in a few min

jeffcho0227 commented 3 years ago

lmeikle commented 3 years ago

Hey @jaredpalmer would you be able to publish this to npm please? 🙏