jaredpalmer / cypress-image-snapshot

Catch visual regressions in Cypress
MIT License
887 stars 160 forks source link

expand cypress peer dependency versions #175

Open jdanil opened 3 years ago

jdanil commented 3 years ago

Expand cypress peer dependency versions to include v5 and v6.

Fixes #168

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: bec2595a5cb2342dc41bc7ba87752e0db502b6b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jdanil commented 3 years ago

@jaredpalmer when you get a chance to review 🙏 Wasn't sure if you preferred caret versions (^) or greater than (>=) to avoid this issue for future major version updates.

Develliot commented 3 years ago

@jaredpalmer +1 for this

We might have to update this again very soon because Cypress 7 is going to come out soon and we will be 3 major versions behind, it's a dev dependency so it's not the end of the world, it's just nice to not have to have multiple version of cypress installed.

jdanil commented 3 years ago

Now that cypress v7 is out, I updated this to a >= check to ensure the new version is included, and any future versions.

@jaredpalmer when you get a chance.

nischi commented 3 years ago

Please merge :) Need this as well

Josmithr commented 3 years ago

Any update on this? I would like this change as well.

pdaether commented 3 years ago

I also would vote for changing this. At the moment I need to run npm i with the --force-flag in my project, which is not a very clean way.

ghost commented 3 years ago

Same as @pdaether . This is completely ruining npm install 😭 @jaredpalmer Please please please

rabelloo commented 2 years ago

I would also love to see this merged.

@crosscompile would you be able to help here? @jaredpalmer seems to be unresponsive for a few months.

ksmills9 commented 1 year ago

Any update on this?