jaredpalmer / cypress-image-snapshot

Catch visual regressions in Cypress
MIT License
887 stars 160 forks source link

Save actual snapshot when encountering an error #177

Open lexanth opened 3 years ago

lexanth commented 3 years ago

Fixes https://github.com/jaredpalmer/cypress-image-snapshot/issues/176

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: 5926801f2409151d5b1b9dc5f851522cc25906f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | cypress-image-snapshot | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lexanth commented 3 years ago

@jaredpalmer Could you give this a review? It would be really helpful for my team if we could get this in.

lexanth commented 3 years ago

@jaredpalmer Hi, any chance we can get this in?

jsdevtom commented 3 years ago

@jaredpalmer Would you like this "actual" to be optional? The code looks good to me

himsachan commented 3 years ago

when this changes will be released ?

shchekoldin commented 2 years ago

This one will be very useful for us. Right now we are applying this patch using post install hook :(

lexanth commented 2 years ago

@jaredpalmer would you be interested in giving some other contributors commit rights? There's a bit of low-hanging fruit in existing PRs that would be nice to get merged, I'm guessing you don't have much time for this at the moment.