search

jaredpalmer / cypress-image-snapshot

Catch visual regressions in Cypress
MIT License
890 stars 159 forks source link

Improvement/update node support to 18 and cypress 10 11 12 #267

Open sosog opened 1 year ago

sosog commented 1 year ago

I have upgraded a few packages to support cypress 10 and also 11 and 12 versions, with nodejs 16.x and 18.x. Babel also should be updated, maybe deep refactoring of js files to ts and removing some packages in the future would be good decisions, otherwise working with this package going to be a headache. I have updated jest-image-snapshot to 5.0.0. version and example react project too, with jest-image-snapshot i had multiple issues which need a lot of time I think to fix so I don't know if there is any sense to do such big job if cypress-image-snapshot packages going to die instead of updating.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 095d547a322cc39bb20e0b2f206d6e181a3bbe9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------- | ----- | | cypress-image-snapshot | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

paperschool commented 1 year ago

@jaredpalmer may I ask who is maintaining this package? I have some small changes id like to make + pr's like this need some love I think! Any chance its worth adding more contributors to give this project some life? Cheers

sosog commented 1 year ago

@paperschool as you can see, no one answered, I have published my fork into NPM, but better to create a new package from scratch. I also found other PR so if there will be interest from other devs we can try to write a package with a modern environment and starter kits.

paperschool commented 1 year ago

@sosog would you say the contents of this package are sufficiently out of date as to not make it worth keeping and republishing? Id be game on recreating it but frankly I am not sure on the intricacies of the entire package. What is worth keeping and what isnt etc.

sosog commented 1 year ago

@paperschool I say it as an option only, because authors are inactive, as you can see I have updated it already, in the future we can switch to TS and just move the logic of this package, but anyway, it's tons of work.

everywebco commented 1 year ago

@jaredpalmer could you help us with this PR?

sosog commented 1 year ago

@jackjocross @MichaelDeBoey @lazarljubenovic

sosog commented 1 year ago

@simonsmith you have similar PR

simonsmith commented 1 year ago

I like the sound of a new package and we can drop all the forks

lazarljubenovic commented 1 year ago

@jackjocross @MichaelDeBoey @lazarljubenovic

What?

sosog commented 1 year ago

@jackjocross @MichaelDeBoey @lazarljubenovic

What?

You are contributor, maybe you have contact with the package author, he is inactive here.

simonsmith commented 1 year ago

I have tried contacting Jared directly on Twitter but no joy. Safe to assume this package will not receive any more updates

sosog commented 1 year ago

@lazarljubenovic not funny...

sosog commented 1 year ago

@simonsmith so we can create maybe some discord chat, to talk about perspectives

lazarljubenovic commented 1 year ago

Just fork the goddamn package.

sosog commented 1 year ago

Just fork the goddamn package.

I don't know where you grew up, but you should be more polite here, and yes this one is already forked, that's the main topic. Bye.

lazarljubenovic commented 1 year ago

I don't know where you grew up, but having a message consist solely of three pings is considered spam. Posting three messages in a row as well.

sosog commented 1 year ago

@simonsmith deprecated in prefer of your package https://www.npmjs.com/package/@sosog/cypress-image-snapshot