Allow multiple snapshots within a single test (Fixes #93)

jaredpalmer / cypress-image-snapshot

Catch visual regressions in Cypress

MIT License

888 stars 160 forks source link

Allow multiple snapshots within a single test (Fixes #93) #96

Open sebinsua opened 5 years ago

sebinsua commented 5 years ago

Allow multiple snapshots within a single test (Fixes #93).

I also fixed a few extra problems I saw:

eslint now allows jest globals.
Async tests don't have unhandled promises. (Fixing this problem meant the snapshot was created.)
process.cwd should be reset even if a test fails.
cypress run --env failOnSnapshotDiff=true should resolve to true (previously the code only considered undefined to be true).

sebinsua commented 5 years ago

@crosscompile Any thoughts? Also - do you know what I need to do to stop Chronicler from failing this build.

/cc @badeball You reported the original issue so linking you, too.

sebinsua commented 5 years ago

@crosscompile Are you happy for this to be merged?

sebinsua commented 4 years ago

@crosscompile @jaredpalmer Are either of you going to be able to merge and publish this?

I've been waiting since August and at this point I'm starting to consider just publishing my own fork.

jasonharrison commented 4 years ago

It seems that this project may have been abandoned. :-( @sebinsua If you publish a fork, let me know.

sebinsua commented 4 years ago

@jasonharrison Yeah, I'm not sure if/when they'll come back to this, so I've created this fork.

I'm just as likely as anybody else within the community to run out of time to maintain this, so what I'll try to do is to follow the Community Continuity Guidelines and give merge access to anybody that gets a contribution in. Hopefully that way we can spread the workload.

badeball commented 4 years ago

I'm sorry for not coming back to you sooner with feedback on this. I've tested the branch and can confirm that it does indeed solve the problem that we initially had. Thanks for your great work! And I hope this can get merged at some point.