Update to React 16.3 (context)

jaredpalmer / formik-effect

Declarative component for managing side-effects in Formik forms. 580 bytes

https://npm.im/formik-effect

MIT License

166 stars 13 forks source link

Update to React 16.3 (context) #9

Closed JulienMalige closed 5 years ago

JulienMalige commented 6 years ago

Hi @jaredpalmer,

I'm trying to update formik-effect to use it with the new Context API (fix #3 #4 #6). The code looks ok for me, but the Formik prop of the Effect consumer is always empty.

Is my code not correct ?

JulienMalige commented 6 years ago

Using this code in our projet (as component, not as library) it works. So the issue must be related to the dependencies.

danielkcz commented 5 years ago

Sooo, why this hasn't been merged yet? :)

danielkcz commented 5 years ago

@JulienMalige Oh, the test is failing because it's trying to run test script, but no such is defined. Can you perhaps add it?

imamatory commented 5 years ago

Any updates?

danielkcz commented 5 years ago

@imamatory Given that Formik is getting rewritten to Hooks, I don't think this PR is relevant anymore. Or at least that functionality of this package will be included in core Formik.