jaredpalmer / formik

Build forms in React, without the tears 😭
https://formik.org
Apache License 2.0
33.71k stars 2.77k forks source link

fix-docs: return type of setValue in docs did not match the function typing #3871

Closed DavideFrancescon closed 9 months ago

DavideFrancescon commented 10 months ago

Function return Docs before changes: setValues: (fields: React.SetStateAction<{ [field: string]: any }>, shouldValidate?: boolean) => void Closes: #3846

changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: 405578c02fbf9d199190924c1201c38b591134c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 3:19pm
codesandbox-ci[bot] commented 10 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 405578c02fbf9d199190924c1201c38b591134c0:

Sandbox Source
Formik TypeScript Playground (forked) Configuration
Formik Codesandbox Template (forked) Issue #3846
Formik Codesandbox Template Issue #3846
withFormik Codesandbox Template Issue #3846
quantizor commented 9 months ago

@DavideFrancescon for whatever reason your branch seems to be having issues staying up to date, could you merge main for me to get this good for merging?

DavideFrancescon commented 9 months ago

@DavideFrancescon for whatever reason your branch seems to be having issues staying up to date, could you merge main for me to get this good for merging?

It SHOULD be okay now, hopefully, let me know if it works! Thanks for your time

DavideFrancescon commented 9 months ago

@probablyup I guess it does not work :')

I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

quantizor commented 9 months ago

@probablyup I guess it does not work :')

I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

I think it's just some transient weirdness, rerunning the job.

DavideFrancescon commented 9 months ago

@probablyup I guess it does not work :') I don't think I can do much about this as mine was only a small change and surely didn't cause this much of a performance issue.

I think it's just some transient weirdness, rerunning the job.

What if I try adding a new commit with like a new-line somewhere just to reset the algorithm?

quantizor commented 9 months ago

Going to fix the check to not run when it's unnecessary → https://github.com/jaredpalmer/formik/pull/3880