jaredpalmer / formik

Build forms in React, without the tears 😭

https://formik.org

Apache License 2.0

33.71k stars 2.77k forks source link

Fixes Margin Issue with Lg screen #3903

Closed webdev-ashishk closed 7 months ago

webdev-ashishk commented 8 months ago

What does this PR do ?

fixes: #3902

Type of change made

added lg:mx-4 in two file first file is index.tsx and second file is footer.tsx

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 694456c0a06e0cfa42f86bfb6f48f115dbf310e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
formik-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2023 5:12pm

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 694456c0a06e0cfa42f86bfb6f48f115dbf310e3:

Sandbox	Source
Formik TypeScript Playground (forked)	Configuration

zoosphar commented 7 months ago

Hello @webdev-ashishk,

I noticed that you added the class lg:mx-4, which is acceptable. However, I also noticed that there are unnecessary changes in both the footer and index files. These changes involve reordering classes on the elements, which can potentially cause conflicts on the main branch when merging or when someone pulls from the origin after merging. To maintain the clarity of the solution you provided, please avoid making these changes.

Thank you.

webdev-ashishk commented 7 months ago

Hello @webdev-ashishk,

I noticed that you added the class lg:mx-4, which is acceptable. However, I also noticed that there are unnecessary changes in both the footer and index files. These changes involve reordering classes on the elements, which can potentially cause conflicts on the main branch when merging or when someone pulls from the origin after merging. To maintain the clarity of the solution you provided, please avoid making these changes.

Thank you.