search

jaredpalmer / formik

Build forms in React, without the tears 😭
https://formik.org
Apache License 2.0
34k stars 2.79k forks source link

fix(3942): added support for NativeSyntheticEvent #3972

Open erashu212 opened 6 months ago

erashu212 commented 6 months ago

Closes #3942

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: ac2a03444dd25c079df89787dd5e5a0a76e6eb4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:04am
codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

quantizor commented 2 months ago

Let's actually just inline the type instead of requiring the user to install react-native if they're not using it, etc:

export interface NativeSyntheticEvent<T>
  extends React.BaseSyntheticEvent<
    T,
    React.ElementRef<React.ComponentType<any>>,
    React.ElementRef<React.ComponentType<any>>
  > {}

And please add a changeset :)