jaredpalmer / formik

Build forms in React, without the tears 😭

https://formik.org

Apache License 2.0

34k stars 2.79k forks source link

fix issue #3455 #3997

Open newbie-k opened 1 month ago

newbie-k commented 1 month ago

3455

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: a29f858547cec29ad026c8528cb5a4227fde8fab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

| Name | Type | | ------------- | ----- | | formik | Major | | formik-native | Patch | | fdocs3 | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
formik-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 29, 2024 2:39pm

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

quantizor commented 1 month ago

That link 404s...

newbie-k commented 1 month ago

@quantizor fixed the link. Also in packages/formik/test/types.test.tsx there is no test for touched or errors array value. Maybe that is why this change is pass ? Might need adding array type value in test file(s) to confirm that this change is working properly.

quantizor commented 1 month ago

https://github.com/jaredpalmer/formik/issues/3455#issuecomment-2401512440