jaredpalmer / the-platform

Web. Components. 😂
MIT License
4.41k stars 118 forks source link

Typing not there #60

Open babakness opened 5 years ago

babakness commented 5 years ago

https://github.com/palmerhq/the-platform/blob/16c0c7ebfa3d8d1e8b92306a8fdfaba064bf6e4a/package.json#L18

Yet installing from npm the

cd node_modules/the-platform find . | grep ts

nada.

babakness commented 5 years ago

Looked into it. The right files are being built but looks like not being uploaded to npm. Using a locally link version for now to get types.

For someone who doesn't want to wait, this worked for me

  1. clone the repo, yarn install
  2. yarn run build
  3. yarn link
  4. go to your project
  5. yarn link the-platform

Be sure yarn unlink the-platform and install from npm when this issue is resolve

peace✌️

babakness commented 5 years ago

Oh, so Script doesn't have "async" as prop (shown in docs with async flag)

babakness commented 5 years ago

image

jaredpalmer commented 5 years ago

Call createRoot to enable conconcurrent React

jaredpalmer commented 5 years ago

Sorry I misread this. Is the file not there?

Pau1fitz commented 5 years ago

@jaredpalmer I am having the same issue

Could not find a declaration file for module 'the-platform'.

Try npm install @types/the-platform if it exists or add a new declaration (.d.ts) file containing declare module 'the-platform';

Is there a solution here?

When I run yarn add the-platform it is js files installed in my nodemodules, and not ts files, but maybe this is expected? ¯_(ツ)

stunaz commented 5 years ago

same issue here

pie6k commented 5 years ago

same issue. seems like final index.d.ts is not making it in published npm files.