search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.22k stars 507 forks source link

Support husky v6 #1006

Open morenyang opened 3 years ago

morenyang commented 3 years ago

Current Behavior

Currently, in tsdx, the configuration of husky uses v4 style. But since husky stores its configuration in .husky directory, the existing configurations are no longer working.

https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v6

Expected behavior

husky works, and be able to run git hooks

Suggested solution(s)

migrate the configurations to support husky v6

Additional context

Your environment

  System:
    OS: Linux 5.4 Ubuntu 20.04 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
    Memory: 9.38 GB / 12.17 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.1/bin/yarn
    npm: 7.9.0 - ~/.nvm/versions/node/v14.16.1/bin/npm
agilgur5 commented 3 years ago

Thanks for bringing this up. It looks like Husky v6 is back to Open Source, so there aren't concerns about incorporating it into TSDX as there were with v5. Seems like there might be some gotchas on the upgrade path though. The not installed by default change should at least partially enable an existing feature request (need to find the issue #, on phone) as well