search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

upgrade to parcel-bundler^1.12.5 from parcel^1.12.3 in templates #1040

Open Catminusminus opened 3 years ago

Catminusminus commented 3 years ago

This will fix #980.

Currently, in the two template projects (react and react-with-storybook), you will encounter "Invalid Version: undefined" errors when you type yarn start in the example directories.

This is due to specifying "parcel": "^1.12.3" in package.json and upgrading to 1.12.5 will fix the problem.

However, v1.12.5 exists only in parcel-bundler package, so I change "parcel": "^1.12.3" to "parcel-bundler": "^1.12.5".

In addition, upgrading to parcel v2 beta will break hot module reloading (https://github.com/formium/tsdx/issues/980#issuecomment-798875545), so I decided to use not parcel v2 but parcel-bundler.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/HzacZy85tBm124gWmtUVknnSFo14
✅ Preview: https://tsdx-git-fork-catminusminus-upgrade-parcelv1-formium.vercel.app

thebiltheory commented 3 years ago

@Catminusminus something seems to be wrong with the checks. Anything we can do to unlock these?

Catminusminus commented 3 years ago

I got the three approvements, so I will explain this situation.

Let me get straight to the point, this project seems to be "dead". See https://github.com/formium/tsdx/issues/1058 for detail. And only you can do Is fork thIs project (or use a forked project like this).

To unlock CI for this PR, an approvement by a reviewer with write access permission is required. And this seems to be impossible now.

binvb commented 3 years ago

I got the three approvements, so I will explain this situation.

Let me get straight to the point, this project seems to be "dead". See #1058 for detail. And only you can do Is fork thIs project (or use a forked project like this).

To unlock CI for this PR, an approvement by a reviewer with write access permission is required. And this seems to be impossible now.

thank you

sidwebworks commented 3 years ago

Just tried adding parcel bundler with the given version @Catminusminus

Although I can now see this console error, 

parcelRequire is not defined

Any ideas what this could be?

sidwebworks commented 3 years ago

image