jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.21k stars 505 forks source link

Error: "prettier/@typescript-eslint" #1056

Open veritem opened 3 years ago

veritem commented 3 years ago

Current Behavior

This package "prettier/@typescript-eslint" has been merged into prettier as of 2021-02-21

These are my packages.

  "devDependencies": {
    "@babel/core": "^7.14.6",
    "@size-limit/preset-small-lib": "^5.0.1",
    "@storybook/addon-essentials": "^6.3.2",
    "@storybook/addon-info": "^5.3.21",
    "@storybook/addon-links": "^6.3.2",
    "@storybook/addons": "^6.3.2",
    "@storybook/react": "^6.3.2",
    "@types/react": "^17.0.13",
    "@types/react-dom": "^17.0.8",
    "babel-loader": "^8.2.2",
    "eslint-config-prettier": "^8.3.0",
    "husky": "^7.0.0",
    "prettier": "^2.3.2",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-is": "^17.0.2",
    "size-limit": "^5.0.1",
    "tsdx": "^0.14.1",
    "tslib": "^2.3.0",
    "typescript": "^4.3.5"
  }

Expected behavior

Linting should work just fine

Suggested solution(s)

Fix linting and migrate from "prettier/@typescript-eslint" to prettier

alvarlagerlof commented 2 years ago

I have the same issue

NikitaDudin commented 2 years ago

Try to use patch-package to override "prettier/@typescript-eslint" in the default config as temporary solution.

  1. Install patch-package:
    yarn add patch-package postinstall-postinstall
  2. Open ./node_modules/tsdx/dist/createEslintConfig.js and remove row 12:
    'prettier/@typescript-eslint',
  3. Save file. Run
    yarn patch-package tsdx
  4. Add postinstall script to scripts in the package.json file: "postinstall": "patch-package"
samlevin commented 2 years ago

getting this as well. any update?

ck-primer commented 2 years ago

The post install script is not really a solution to this issue, it's a work around. Has there been any progress with this bug?