jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.2k stars 505 forks source link

Default github workflow has old version of node - throws error #1104

Closed SuperWallaby closed 2 years ago

SuperWallaby commented 2 years ago

Current Behavior

If you do npx tsdx create mylib and select the base and push it, an error occurs in the github flow.
The error content is that node 10.x is not compatible with the dependency @size-limit/esbuild@7.0.4: module.

Suggested solution(s)

main.yml

...
    strategy:
      matrix:
        node: ['10.x', '12.x', '14.x']
        os: [ubuntu-latest, windows-latest, macOS-latest]
...

should be

...
    strategy:
      matrix:
        node: [ '12.x', '14.x']
        os: [ubuntu-latest, windows-latest, macOS-latest]
...

then it works fine.

agilgur5 commented 2 years ago

Duplicate of #1089

Thanks for providing a quick fix for readers. Other method is to pin size-limit to a version that supports Node 10.