jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

(fix): change plugin order to make styled-components/macro work #644

Closed agilgur5 closed 4 years ago

agilgur5 commented 4 years ago

(test): update styled-component template tag test to reflect the slightly different tag due to the usage of the macro

(fix/test): comment removal should use toBeFalsy, not toBeTruthy, since it's removed

Workaround for #543

Should go out in a minor since it's possible changing the order of this one plugin could break some things, but highly unlikely

zebapy commented 4 years ago

Is this going to get merged? What's holding it back?

agilgur5 commented 4 years ago

@zebapy per the PR description, label, and milestone, it's a breaking change and will go out in v0.14.0

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/9cadrq5hv
✅ Preview: https://tsdx-git-fork-agilgur5-fix-styled-components-macro.formium.vercel.app