Closed agilgur5 closed 4 years ago
Is this going to get merged? What's holding it back?
@zebapy per the PR description, label, and milestone, it's a breaking change and will go out in v0.14.0
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/formium/tsdx/9cadrq5hv
✅ Preview: https://tsdx-git-fork-agilgur5-fix-styled-components-macro.formium.vercel.app
if babel-plugin-macros is first, macros get applied first
based on babel-plugin-styled-component's code, docs, and output in detail, I think its ordering conflict may be with babel-plugin-annotate-pure-calls, which so happens to be the first plugin in babelPluginTsdx
(test): update styled-component template tag test to reflect the slightly different tag due to the usage of the macro
(fix/test): comment removal should use toBeFalsy, not toBeTruthy, since it's removed
Workaround for #543
Should go out in a minor since it's possible changing the order of this one plugin could break some things, but highly unlikely