(fix): remove faulty tsconfig.json include of test dir

[agilgur5]

• include means all files that should be compiled, and the test dir should definitely not be compiled

  • this was causing issues where declarations were being output into dist/ for all files in test/
  • that shouldn't happen and it means build was unnecessarily slowed down in order to process test/ files
  • default exclude that was added of .spec/.test files, originally for co-located tests, ended up making most test/ dir files excluded too, but not, say, test utils that don't have a .spec or .test suffix

• this was also causing errors with the rootDir: './src' change as the test/ dir is outside of the rootDir

  • problem wasn't the rootDir, but that the test/ dir shouldn't be compiled or processed in any way

(test): ensure test/.test.ts and test/.ts files are correctly excluded and don't have declarations generated

• and that they don't error with rootDir: './src'

(test): ensure types/*.d.ts don't error with rootDir and don't have declarations re-generated either

• n.b. tsc won't re-generate them either, they don't get copied to outDir, this isn't new or different behavior

(env/test): Jest shouldn't run / should ignore tests inside of fixtures

---

Fixes #638 , the root cause of it, and adds tests for this.

Effectively reverts #226 . I haven't been able to reproduce #225 / #84 in my VS Code, but maybe that's because I have it configured a little differently? Would like to add VS Code integration tests so there's an automated way to check that it works independently on CI without any configuration (and so I don't have to attempt and fail to test this on my own machine). But tsc --noEmit at least, indeed doesn't output errors in test/ anymore. tsdx lint still does. Per my comments in #638 if this and the VS Code integration are problematic, we should move this to a tsconfig.build.json and then have a plain tsconfig.json that extends from it and changes include to './' so everything is type-checked.

[kylemh]

Does this mean we'd also wanna avoid compiling stories (Storybook)?

[agilgur5]

@kylemh yes, your stories shouldn't be in your include, otherwise they'll be unnecessarily compiled (and output to dist/likely unnecessarily published).

The Storybook template doesn't have them in the include as you can see here. Are yours by chance co-located? We could add **/*.stories.tsx to the default exclude if it's a common enough pattern (I've seen it a few times).

The approach I listed in https://github.com/jaredpalmer/tsdx/issues/638#issuecomment-605728767, especially with file: ['src/index.ts'] is optimal, but unfortunately seems to have issues in upstream rpts2 as a I mentioned there.

[kylemh]

So I’m doing monorepo shit in a personal project first before I try to come up with a template to resolve #122

https://github.com/innocuous-tech/core

I’ve got it all flying for now, but I can’t see how to prevent the stories’ typings from getting compiled into the bundle.

I have it excluded, but it’s not working... what do you think?

[agilgur5]

Ah yours are like semi-colocated, in the src dir but as separate dirs. I'd leave them outside of src for a template fwiw. Probably just need to mess with the globs a bit. If you moved the exclude into each package it would probably be easier to figure out. Path resolution is a bit weird with extends too but you seem to be using it correctly so I'm not sure.

[kylemh]

Hmmmm I remember reading somewhere that @jaredpalmer prefers colocating tests with source code. Having the answer be “don’t do that” doesn’t seem ideal or in line with the opinions of this repo’s author.

I’ll try manually listing the excludes in each package, but that wasn’t working either.

[agilgur5]

Well none of the existing templates have co-located tests or stories, so it wouldn't make sense to add a monorepo template that is the odd one out with semi-colocated tests. Would be very inconsistent and confusing to users

[kylemh]

So this is my individual use case. I can make the template match the rest. The point I’m making is that we should be able to have collocated tests and stories.

In my example, test files are ignored but not stories, so I was just tryna make sure it wasn’t something under the hood. Not extending and excluding per package seems to be working. I’ll have to figure out where I’m going wrong with extends

[agilgur5]

The include/exclude handling should work the same as tsc, the only difference is that TSDX has a default exclude for fully co-located tests (if you're adding your own it doesn't matter). Though it's possible there are bugs with rpts2 as that's one reason why I haven't moved templates to just a files set-up which wouldn't be impacted by location at all, only by imports.