search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.28k stars 507 forks source link

Update shelljs to 0.8.4 to prevent circular dependency in Node v14 #720

Closed rockmandash closed 4 years ago

rockmandash commented 4 years ago

Current Behavior

Run tsdx test in Node v14 will output this warning

Expected behavior

Output no warnings.

Suggested solution

Simply upgrade shelljs to 0.8.4 will solve this problem

Additional context

Your environment

Software Version(s)
TSDX 0.13.2
TypeScript 3.8.3
Browser Chrome 81
npm/Yarn yarn
Node 14
Operating System Mac 10.15.4
agilgur5 commented 4 years ago

So TSDX has ^0.8.3 in the package.json. A patch bump fits into the range, so you don't need TSDX to update that, you can update your yarn.lock or reinstall TSDX and you'll have the newer version of shelljs