jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.28k stars 507 forks source link

Update @rollup/plugin-node-resolve to the latest version πŸš€ #726

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! πŸ’œ πŸššπŸ’¨ πŸ’š

Find out how to migrate to Snyk at greenkeeper.io


The dependency @rollup/plugin-node-resolve was updated from 7.1.3 to 8.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: shellscape License: MIT

Find out more about this release.


FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper bot :palm_tree:

agilgur5 commented 4 years ago

Changelog is not super helpful, says default exports were added but not why that's a breaking major instead of a minor. EDIT: Per the two changes labeled as breaking, https://github.com/rollup/plugins/pull/301 and https://github.com/rollup/plugins/pull/361, it's because it changes exports from CJS to ESM. It also adds a DEFAULTS variable which is actually useful since we copy that right now and have a comment to be explicit about it

v9 is also out which similarly has a not super helpful Changelog entry that says deps were updated but again not why that's breaking instead of patch or minor. Looking at the specific commit, seems to be because it makes it Node 10+ only.

This PR only updates to v8, but we probably want to supersede it with one for v9 that will be Node 10+ as a result

agilgur5 commented 4 years ago

Superseded by #879